[llvm] [arm64] Add tan intrinsic lowering (PR #94545)

Paschalis Mpeis via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 6 10:46:59 PDT 2024


https://github.com/paschalis-mpeis requested changes to this pull request.

Can you please add the sleef tests as well, in
- replace-with-veclib-sleef-scalable.ll
- replace-with-veclib-sleef.ll

This should be the equivalent you did for ArmPL (replace-with-veclib-armpl.ll).


Regarding the TLI mappings, the symbols do exist in the libraries SLEEF and ArmPL (libsleefgnuabi.so and libamath.so respectively).

The code changes look reasonable to me as well, but no strong opinion on areas I haven't touched (fast/global isels, darwin changes).

https://github.com/llvm/llvm-project/pull/94545


More information about the llvm-commits mailing list