[llvm] [HWASan] add optimization remarks for ignoreAccess (PR #94551)

Florian Mayer via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 6 10:04:17 PDT 2024


================
@@ -337,13 +337,17 @@ class HWAddressSanitizer {
                                  unsigned AccessSizeIndex,
                                  Instruction *InsertBefore, DomTreeUpdater &DTU,
                                  LoopInfo *LI);
-  bool ignoreMemIntrinsic(MemIntrinsic *MI);
+  bool ignoreMemIntrinsic(OptimizationRemarkEmitter &ORE, MemIntrinsic *MI);
   void instrumentMemIntrinsic(MemIntrinsic *MI);
   bool instrumentMemAccess(InterestingMemoryOperand &O, DomTreeUpdater &DTU,
                            LoopInfo *LI);
   bool ignoreAccess(Instruction *Inst, Value *Ptr);
+  bool ignoreAccessWithRemark(OptimizationRemarkEmitter &ORE, Instruction *Inst,
----------------
fmayer wrote:

OK. Swapped the other one to be `WithoutRemark`. I can also do overloading, but that makes it easier to accidentally use the wrong one. But I don't care either way.

https://github.com/llvm/llvm-project/pull/94551


More information about the llvm-commits mailing list