[llvm] [SystemZ] Remove getInliningThresholdMultiplier() override (PR #94612)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 6 06:08:09 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-systemz
Author: Nikita Popov (nikic)
<details>
<summary>Changes</summary>
Using this TTI hook is only appropriate for GPU targets that need to maximally flatten all functions.
The inlining threshold multiplier should not be increased for ordinary targets -- while this may increase benchmark scores, it can also result in large code size increases and runaway inlining, resulting in build OOM/timeouts.
---
Full diff: https://github.com/llvm/llvm-project/pull/94612.diff
1 Files Affected:
- (modified) llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.h (-1)
``````````diff
diff --git a/llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.h b/llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.h
index 3cf4a69ac2818..18effe6950e6c 100644
--- a/llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.h
+++ b/llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.h
@@ -38,7 +38,6 @@ class SystemZTTIImpl : public BasicTTIImplBase<SystemZTTIImpl> {
/// \name Scalar TTI Implementations
/// @{
- unsigned getInliningThresholdMultiplier() const { return 3; }
unsigned adjustInliningThreshold(const CallBase *CB) const;
InstructionCost getIntImmCost(const APInt &Imm, Type *Ty,
``````````
</details>
https://github.com/llvm/llvm-project/pull/94612
More information about the llvm-commits
mailing list