[llvm] [RISCV] Remove VPseudoBinaryMOutNoMask. NFC (PR #94531)
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 5 13:03:00 PDT 2024
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/94531
It appears to be identical to VPseudoBinaryNoMask. The comment above it doesn't make sense since VPseudoBinaryNoMask doesn't restrict the destination register to not include V0. Looks like a copy/paste from VPseudoBinaryMOutMask.
>From e93350f14515db9827b8b30c23190a9bc1aff925 Mon Sep 17 00:00:00 2001
From: Craig Topper <craig.topper at sifive.com>
Date: Wed, 5 Jun 2024 13:01:21 -0700
Subject: [PATCH] [RISCV] Remove VPseudoBinaryMOutNoMask. NFC
It appears to be identical to VPseudoBinaryNoMask. The comment
above it doesn't make sense since VPseudoBinaryNoMask doesn't restrict
the destination register to not include V0. Looks like a copy/paste
from VPseudoBinaryMOutMask.
---
.../Target/RISCV/RISCVInstrInfoVPseudos.td | 22 ++-----------------
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td b/llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
index 5fe5a7a5bd5cc..e97048f5a90f0 100644
--- a/llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
+++ b/llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
@@ -1422,24 +1422,6 @@ class VPseudoTernaryMaskPolicyRoundingMode<VReg RetClass,
let UsesVXRM = 0;
}
-// Like VPseudoBinaryNoMask, but output can be V0.
-class VPseudoBinaryMOutNoMask<VReg RetClass,
- VReg Op1Class,
- DAGOperand Op2Class,
- string Constraint,
- int TargetConstraintType = 1> :
- Pseudo<(outs RetClass:$rd),
- (ins Op1Class:$rs2, Op2Class:$rs1, AVL:$vl, ixlenimm:$sew), []>,
- RISCVVPseudo {
- let mayLoad = 0;
- let mayStore = 0;
- let hasSideEffects = 0;
- let Constraints = Constraint;
- let TargetOverlapConstraintType = TargetConstraintType;
- let HasVLOp = 1;
- let HasSEWOp = 1;
-}
-
// Like VPseudoBinaryMask, but output can be V0.
class VPseudoBinaryMOutMask<VReg RetClass,
RegisterClass Op1Class,
@@ -2172,8 +2154,8 @@ multiclass VPseudoBinaryM<VReg RetClass,
int TargetConstraintType = 1,
bit Commutable = 0> {
let VLMul = MInfo.value, isCommutable = Commutable in {
- def "_" # MInfo.MX : VPseudoBinaryMOutNoMask<RetClass, Op1Class, Op2Class,
- Constraint, TargetConstraintType>;
+ def "_" # MInfo.MX : VPseudoBinaryNoMask<RetClass, Op1Class, Op2Class,
+ Constraint, TargetConstraintType>;
let ForceTailAgnostic = true in
def "_" # MInfo.MX # "_MASK" : VPseudoBinaryMOutMask<RetClass, Op1Class,
Op2Class, Constraint, TargetConstraintType>,
More information about the llvm-commits
mailing list