[lld] [ELF] Orphan placement: remove hasInputSections condition (PR #93761)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 09:40:34 PDT 2024


MaskRay wrote:

> I found that `llvm-project/lld/test/ELF/linkerscript/orphan-live-only.s` failed after applying this patch. It looks like this was mentioned in an earlier comment, but it doesn't look like that change has made it into the tests. I could be doing something wrong, so please ignore me if I have.
> 
> I agree that the change to orphan-live-only.s is reasonable.

`orphan-live-only.s` would fail if #94099 is not applied.

The description mentioned `orphan-live-only.s`. The test is not unmodified. Corrected the description.

> I've also run the `bin/ld.lld -shared test.o -T test.t -o test.so` from an earlier comment and that also gives a good result with the change
> 
> I think the non-alloc synthetic section placement could do with some improvement but I think that would have to be done with a separate patch.

Perhaps we do need a `!SHF_ALLOC orphan => at the end` special case.


https://github.com/llvm/llvm-project/pull/93761


More information about the llvm-commits mailing list