[clang] [llvm] [AArch64] Decouple feature dependency expansion. (PR #94279)
Alexandros Lamprineas via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 5 09:38:34 PDT 2024
================
@@ -1110,23 +1071,26 @@ ParsedTargetAttr AArch64TargetInfo::parseTargetAttr(StringRef Features) const {
bool FoundArch = false;
auto SplitAndAddFeatures = [](StringRef FeatString,
- std::vector<std::string> &Features) {
+ std::vector<std::string> &Features,
+ llvm::AArch64::ExtensionSet &FeatureBits) {
SmallVector<StringRef, 8> SplitFeatures;
FeatString.split(SplitFeatures, StringRef("+"), -1, false);
for (StringRef Feature : SplitFeatures) {
- StringRef FeatureName = llvm::AArch64::getArchExtFeature(Feature);
- if (!FeatureName.empty())
- Features.push_back(FeatureName.str());
+ if (FeatureBits.parseModifier(Feature, /* AllowNoDashForm = */ true))
----------------
labrinea wrote:
AllowNoDashForm should perhaps be set to false here?
https://github.com/llvm/llvm-project/pull/94279
More information about the llvm-commits
mailing list