[clang] [llvm] [AArch64] Decouple feature dependency expansion. (PR #94279)

[Alexandros Lamprineas via llvm-commits]

================
@@ -250,13 +248,17 @@ void AArch64::ExtensionSet::addArchDefaults(const ArchInfo &Arch) {
 bool AArch64::ExtensionSet::parseModifier(StringRef Modifier) {
   LLVM_DEBUG(llvm::dbgs() << "parseModifier(" << Modifier << ")\n");
 
-  bool IsNegated = Modifier.starts_with("no");
-  StringRef ArchExt = IsNegated ? Modifier.drop_front(2) : Modifier;
+  size_t NChars = 0;
+  if (Modifier.starts_with("no-"))
----------------
labrinea wrote:

Unfortunately yes.. But what should we do, create different parsing methods for march, target, target_version/clones? They are almost identical. I am not opposing, just wondering what is best.

https://github.com/llvm/llvm-project/pull/94279