[llvm] [LegalizeTypes] Handle non byte-sized elt types when splitting INSERT/EXTRACT_VECTOR_ELT (PR #93357)

Björn Pettersson via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 5 01:59:53 PDT 2024


bjope wrote:

> > So it seems to make more sense in-tree (given by what ValueTypes.td currently looks like) to make use of getRoundIntegerType here. Or alternatively we should do something slightly more complicated by trying to find a legal type for ISD::STORE. But I don't know if there already exist some helper for that or if we would need to invent it.
> > I'll try to update this PR to use getRoundIntegerType instead of the getStoreSizedIntegerVectorElementType. And then we will deal with it downstream, if we want special handling for types like i24.
> 
> getTypeToTransformTo?

That one could perhaps be used in some way. But I don't think it really guarantees to return a type that isn't using a packed layout when used as a vector element type etc. I think it would complicate the code a bit if using that one instead of getRoundIntegerType.


https://github.com/llvm/llvm-project/pull/93357


More information about the llvm-commits mailing list