[llvm] llvm/include/llvm/DebugInfo/CodeView/TypeHashing.h: 2 * pointless copy (#94385) (PR #94410)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 4 16:11:47 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-debuginfo
Author: None (akshaykumars614)
<details>
<summary>Changes</summary>
modified parameters for code quality
---
Full diff: https://github.com/llvm/llvm-project/pull/94410.diff
1 Files Affected:
- (modified) llvm/include/llvm/DebugInfo/CodeView/TypeHashing.h (+2-2)
``````````diff
diff --git a/llvm/include/llvm/DebugInfo/CodeView/TypeHashing.h b/llvm/include/llvm/DebugInfo/CodeView/TypeHashing.h
index e92ec4855b252..453b38e0c11e3 100644
--- a/llvm/include/llvm/DebugInfo/CodeView/TypeHashing.h
+++ b/llvm/include/llvm/DebugInfo/CodeView/TypeHashing.h
@@ -212,8 +212,8 @@ template <> struct DenseMapInfo<codeview::GloballyHashedType> {
return *reinterpret_cast<const unsigned *>(Val.Hash.data());
}
- static bool isEqual(codeview::GloballyHashedType LHS,
- codeview::GloballyHashedType RHS) {
+ static bool isEqual(const codeview::GloballyHashedType &LHS,
+ const codeview::GloballyHashedType &RHS) {
return LHS == RHS;
}
};
``````````
</details>
https://github.com/llvm/llvm-project/pull/94410
More information about the llvm-commits
mailing list