[lld] [llvm] [llvm-readobj][COFF] Consistent PDBGUID Formatting (PR #94256)

Miguel A. Arroyo via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 09:15:58 PDT 2024


================
@@ -793,7 +794,10 @@ void COFFDumper::printCOFFDebugDirectory() {
       DictScope PDBScope(W, "PDBInfo");
       W.printHex("PDBSignature", DebugInfo->Signature.CVSignature);
       if (DebugInfo->Signature.CVSignature == OMF::Signature::PDB70) {
-        W.printBinary("PDBGUID", ArrayRef(DebugInfo->PDB70.Signature));
+        SmallString<38> FormattedGUIDStr;
+        raw_svector_ostream OS(FormattedGUIDStr);
----------------
mayanez wrote:

Yes, that works! I've added the change. 

Let me know if you think we should keep the `operator<<` support or not. I'm inclined to keep it for consistency with the rest of the types.

https://github.com/llvm/llvm-project/pull/94256


More information about the llvm-commits mailing list