[llvm] [AMDGPU][WIP] Optimize SGPR spills (PR #93668)

Christudasan Devadasan via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 4 07:20:15 PDT 2024


================
@@ -1775,8 +1775,10 @@ bool SIRegisterInfo::spillSGPR(MachineBasicBlock::iterator MI, int Index,
 
   if (SpillToVGPR) {
 
-    assert(SB.NumSubRegs == VGPRSpills.size() &&
-           "Num of VGPR lanes should be equal to num of SGPRs spilled");
+    assert(SB.NumSubRegs <= VGPRSpills.size() &&
+           "Num of VGPR lanes should be greater or equal to num of SGPRs "
----------------
cdevadas wrote:

Keep this string as concise as possible. Any extra details you want to add should be included in a comment statement before the assert. The original string looks good. You might want to change "should be equal to" -> "should be less or equal to".

https://github.com/llvm/llvm-project/pull/93668


More information about the llvm-commits mailing list