[llvm] 4ee950e - update_test_checks: support more arm64_32-apple-watchos triples

Jon Roelofs via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 15:37:21 PDT 2024


Author: Jon Roelofs
Date: 2024-06-03T15:34:06-07:00
New Revision: 4ee950e75d40e335adb2d470b532d7375733f665

URL: https://github.com/llvm/llvm-project/commit/4ee950e75d40e335adb2d470b532d7375733f665
DIFF: https://github.com/llvm/llvm-project/commit/4ee950e75d40e335adb2d470b532d7375733f665.diff

LOG: update_test_checks: support more arm64_32-apple-watchos triples

Having the version in `get_run_handlers` meant that a RUN line without the
version in it would not match, and therefore UTC would generate a useless
catch-all check of the form:

```
;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
; CHECK: {{.*}}
```

This patch also adds `arm64_32` as a base-level run handler, and assumes it
will always apply to a darwin target (which is currently the case for all
arm64_32-* triples I see in tree currently).

Added: 
    

Modified: 
    llvm/test/CodeGen/AArch64/lower-ptrmask-arm64_32.ll
    llvm/utils/UpdateTestChecks/asm.py

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/AArch64/lower-ptrmask-arm64_32.ll b/llvm/test/CodeGen/AArch64/lower-ptrmask-arm64_32.ll
index 3f0a2640b6ad8..d1222032c2d64 100644
--- a/llvm/test/CodeGen/AArch64/lower-ptrmask-arm64_32.ll
+++ b/llvm/test/CodeGen/AArch64/lower-ptrmask-arm64_32.ll
@@ -1,5 +1,5 @@
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
-; RUN: llc -mtriple=arm64_32-apple-watchos2.0.0 %s -o - | FileCheck %s
+; RUN: llc -mtriple=arm64_32-apple-watchos %s -o - | FileCheck %s
 
 define ptr @issue94075(ptr %p) {
 ; CHECK-LABEL: issue94075:

diff  --git a/llvm/utils/UpdateTestChecks/asm.py b/llvm/utils/UpdateTestChecks/asm.py
index cce00e4a28027..4dc50d95fef9b 100644
--- a/llvm/utils/UpdateTestChecks/asm.py
+++ b/llvm/utils/UpdateTestChecks/asm.py
@@ -534,8 +534,9 @@ def get_run_handler(triple):
         "i686": (scrub_asm_x86, ASM_FUNCTION_X86_RE),
         "x86": (scrub_asm_x86, ASM_FUNCTION_X86_RE),
         "i386": (scrub_asm_x86, ASM_FUNCTION_X86_RE),
+        "arm64_32": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
         "arm64_32-apple-ios": (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),
-        "arm64_32-apple-watchos2.0.0": (
+        "arm64_32-apple-watchos": (
             scrub_asm_arm_eabi,
             ASM_FUNCTION_AARCH64_DARWIN_RE,
         ),


        


More information about the llvm-commits mailing list