[lld] [llvm] [llvm-readobj][COFF] Consistent PDBGUID Formatting (PR #94256)
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 3 15:14:59 PDT 2024
================
@@ -793,7 +794,10 @@ void COFFDumper::printCOFFDebugDirectory() {
DictScope PDBScope(W, "PDBInfo");
W.printHex("PDBSignature", DebugInfo->Signature.CVSignature);
if (DebugInfo->Signature.CVSignature == OMF::Signature::PDB70) {
- W.printBinary("PDBGUID", ArrayRef(DebugInfo->PDB70.Signature));
+ SmallString<38> FormattedGUIDStr;
+ raw_svector_ostream OS(FormattedGUIDStr);
----------------
rnk wrote:
You can stream directly through the ScopedPrinter rather than preparing a string first, try this instead:
W.startLine() << "PDBGUID: " << fmt_guid(...) << '\n';
https://github.com/llvm/llvm-project/pull/94256
More information about the llvm-commits
mailing list