[llvm] [LAA] Always use DepCands when grouping runtime checks. (PR #91196)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 3 10:40:12 PDT 2024

Previous message: [compiler-rt] [llvm] [Memprof] Adds the option to collect AccessCountHistograms for memprof. (PR #94264)
Next message: [llvm] [LAA] Always use DepCands when grouping runtime checks. (PR #91196)
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

https://github.com/preames approved this pull request.

LGTM - but please consider this a weak one.  The structure of this code (both before and after your change) confuses me, and while your change looks reasonable, I'm not sure I'm not missing something.  

https://github.com/llvm/llvm-project/pull/91196

Previous message: [compiler-rt] [llvm] [Memprof] Adds the option to collect AccessCountHistograms for memprof. (PR #94264)
Next message: [llvm] [LAA] Always use DepCands when grouping runtime checks. (PR #91196)
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list