[llvm] Revert "fix(utils/**.py): fix comparison to None" (PR #94261)
Jordan Rupprecht via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 3 10:19:04 PDT 2024
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/94261
Reverts llvm/llvm-project#94022
This is not actually valid bazel syntax
>From f2547220a2c1dbc6f50b8b5b679d1131b6d9493c Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht <jordanrupprecht at gmail.com>
Date: Mon, 3 Jun 2024 12:15:56 -0500
Subject: [PATCH] Revert "fix(utils/**.py): fix comparison to None (#94022)"
This reverts commit f873dd2c8d539378a5118da595ea3fba17ee2e73.
---
utils/bazel/configure.bzl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/utils/bazel/configure.bzl b/utils/bazel/configure.bzl
index 9c3bb321a5afa..717b86d7d6e8a 100644
--- a/utils/bazel/configure.bzl
+++ b/utils/bazel/configure.bzl
@@ -110,7 +110,7 @@ def _extract_cmake_settings(repository_ctx, llvm_cmake):
# Skip if `CMAKE_CXX_STANDARD` is set with
# `LLVM_REQUIRED_CXX_STANDARD`.
# Then `v` will not be desired form, like "${...} CACHE"
- if c[k] is not None:
+ if c[k] != None:
continue
# Pick up 1st word as the value.
@@ -160,7 +160,7 @@ def _llvm_configure_impl(repository_ctx):
repository_ctx,
"cmake/Modules/LLVMVersion.cmake",
)
- version = {k: v for k, v in version.items() if v is not None}
+ version = {k: v for k, v in version.items() if v != None}
vars.update(version)
_write_dict_to_file(
More information about the llvm-commits
mailing list