[llvm] [llvm-profgen] Add pgo accuracy metrics (PR #93975)

via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 2 23:07:59 PDT 2024


lifengxiang1025 wrote:

> > Yes, we can. We only need bbaddrmap setcion information in a binary. But for the tool llvm-profgen, i think it's normal to use binary as input.
> 
> Just because it's the norm does not mean it's good. Having a binary in the tree makes things significantly harder to audit from a security perspective, on top of making the test significantly less readable without using an external tool like `llvm-objdump`. If a test involving a binary can be written using `yaml2obj`, it should be.

Thanks. Got it. I'll fix the testcase soon.

https://github.com/llvm/llvm-project/pull/93975


More information about the llvm-commits mailing list