[llvm] [RFC][AMDGPU] Remove old llvm.amdgcn.buffer.* and tbuffer intrinsics (PR #93801)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Thu May 30 08:46:33 PDT 2024


jayfoad wrote:

> MLIR does not meaningfully depend on those intrinsics.
> 
> No current lowering uses the wrappers we have around those intrinsics.
> 
> Those wrappers are defined at https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Dialect/LLVMIR/ROCDLOps.td#L428-L464 and are the same sort of "legacy infrastructure, do not use" as the intrinsics you're planning to remove in this PR.
> 
> You should be able to just delete the highlighted bit and any code that tries to refer to those (mainly their parsers and printers over in `mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp` and the tests for the translation of those operations.

Thanks! I've tried that in #93838.

https://github.com/llvm/llvm-project/pull/93801


More information about the llvm-commits mailing list