[llvm] [AMDGPU][RFC] Combine asm and disasm tests. (PR #90214)
Ivan Kosarev via llvm-commits
llvm-commits at lists.llvm.org
Thu May 30 06:26:43 PDT 2024
kosarev wrote:
> Not sure I am following. It seems that `-filetype=hex` output is piped to `llvm-mc -disassemble`.
> ```
> llvm-mc -filetype=hex a.s | llvm-mc -disassemble
> ```
> How is this more convenient than `llvm-mc -filetype=obj a.s | llvm-objdump -d -`?
I think this was already asked and answered above. To reiterate, `llvm-mc -disassemble` produces its output in the same format as `llvm-mc`, so we can use the same check directives for both assembler and dissasembler tests. Using `llvm-objdump -d -` would require multiple directives per instruction, which is not an improvement -- on top of other inconveniences explained earlier.
> Can you analyze a mini example including the assembly source and llvm-mc/llvm-objdump command lines for clearer evaluation?
I'm not sure I understand the question. llvm/test/MC/AMDGPU/gfx12_asm_vop1.s in this pull request should hopefully serve as an example, if that's the ask.
https://github.com/llvm/llvm-project/pull/90214
More information about the llvm-commits
mailing list