[llvm] [AMDGPU] Implemented a patch to optimize SGPR spills (PR #93668)

Vikash Gupta via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 20:43:20 PDT 2024


================
@@ -67,6 +67,9 @@ namespace {
     const MachineBlockFrequencyInfo *MBFI = nullptr;
     SlotIndexes *Indexes = nullptr;
 
+    // - preserves Analysis passes in case RA may be called afterwards.
+    bool preserveRegAllocNeededAnalysis = false;
----------------
vg0204 wrote:

> There shouldn't be a reason to have a configuration flag for this. The pass can just unconditionally preserve the analyses.
> 
> This should also be a separate PR, not just a separate commit in this PR

ok sure, I should put changes in generic pass as separate PR.

But, as the same stackSlotColoring pass exists in generic way(after RA) for other Target's pipeline where these analysis are not really required to be preserved. As in this case, it just got additionally called in between AMDGPU target pipeline(where addtional analysis needs to be preserved). Therefore, got suggested to introduce this flag to avoid avoid any changes for other architecture's pipeline( maybe caused due to additional pass preserving in stackSlotColoring).

https://github.com/llvm/llvm-project/pull/93668


More information about the llvm-commits mailing list