[llvm] [llvm-config] Make llvm-config --system-libs obey LLVM_USE_STATIC_ZSTD. (PR #93754)
via llvm-commits
llvm-commits at lists.llvm.org
Wed May 29 17:12:50 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-support
Author: Kyle Huey (khuey)
<details>
<summary>Changes</summary>
LLVM's build system does the right thing but LLVM_SYSTEM_LIBS ends up containing the shared library. Emit the static library instead when appropriate.
CC @<!-- -->MaskRay since zstd compression is relevant to his interests.
---
Full diff: https://github.com/llvm/llvm-project/pull/93754.diff
1 Files Affected:
- (modified) llvm/lib/Support/CMakeLists.txt (+6-2)
``````````diff
diff --git a/llvm/lib/Support/CMakeLists.txt b/llvm/lib/Support/CMakeLists.txt
index 03e888958a071..1ab5bd370c480 100644
--- a/llvm/lib/Support/CMakeLists.txt
+++ b/llvm/lib/Support/CMakeLists.txt
@@ -321,8 +321,12 @@ if(LLVM_ENABLE_ZSTD)
if(NOT zstd_library)
get_property(zstd_library TARGET ${zstd_target} PROPERTY LOCATION)
endif()
- get_library_name(${zstd_library} zstd_library)
- set(llvm_system_libs ${llvm_system_libs} "${zstd_library}")
+ if (zstd_target STREQUAL zstd::libzstd_shared)
+ get_library_name(${zstd_library} zstd_library)
+ set(llvm_system_libs ${llvm_system_libs} "${zstd_library}")
+ else()
+ set(llvm_system_libs ${llvm_system_libs} "${zstd_STATIC_LIBRARY}")
+ endif()
endif()
if(LLVM_ENABLE_TERMINFO)
``````````
</details>
https://github.com/llvm/llvm-project/pull/93754
More information about the llvm-commits
mailing list