[llvm] cd5045a - [ValueTypes] Use bit instead of int for boolean fields in ValueTypes.td. NFC
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Wed May 29 08:16:06 PDT 2024
Author: Craig Topper
Date: 2024-05-29T08:15:49-07:00
New Revision: cd5045a76a02f87542b2ff3d78352c10aee6395b
URL: https://github.com/llvm/llvm-project/commit/cd5045a76a02f87542b2ff3d78352c10aee6395b
DIFF: https://github.com/llvm/llvm-project/commit/cd5045a76a02f87542b2ff3d78352c10aee6395b.diff
LOG: [ValueTypes] Use bit instead of int for boolean fields in ValueTypes.td. NFC
Added:
Modified:
llvm/include/llvm/CodeGen/ValueTypes.td
llvm/utils/TableGen/VTEmitter.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/CodeGen/ValueTypes.td b/llvm/include/llvm/CodeGen/ValueTypes.td
index e322cc04c1c76..0d8eaf1b2b1dd 100644
--- a/llvm/include/llvm/CodeGen/ValueTypes.td
+++ b/llvm/include/llvm/CodeGen/ValueTypes.td
@@ -18,11 +18,11 @@ class ValueType<int size, int value> {
int Value = value;
int nElem = 1;
ValueType ElementType = ?;
- int isOverloaded = false;
- int isInteger = false;
- int isFP = false;
- int isVector = false;
- int isScalable = false;
+ bit isOverloaded = false;
+ bit isInteger = false;
+ bit isFP = false;
+ bit isVector = false;
+ bit isScalable = false;
}
class VTAny<int value> : ValueType<0, value> {
diff --git a/llvm/utils/TableGen/VTEmitter.cpp b/llvm/utils/TableGen/VTEmitter.cpp
index 5ec1f59318f78..9174fe48b62a9 100644
--- a/llvm/utils/TableGen/VTEmitter.cpp
+++ b/llvm/utils/TableGen/VTEmitter.cpp
@@ -68,10 +68,10 @@ void VTEmitter::run(raw_ostream &OS) {
continue;
auto Name = VT->getValueAsString("LLVMName");
auto Value = VT->getValueAsInt("Value");
- bool IsInteger = VT->getValueAsInt("isInteger");
- bool IsFP = VT->getValueAsInt("isFP");
- bool IsVector = VT->getValueAsInt("isVector");
- bool IsScalable = VT->getValueAsInt("isScalable");
+ bool IsInteger = VT->getValueAsBit("isInteger");
+ bool IsFP = VT->getValueAsBit("isFP");
+ bool IsVector = VT->getValueAsBit("isVector");
+ bool IsScalable = VT->getValueAsBit("isScalable");
UpdateVTRange("INTEGER_FIXEDLEN_VECTOR_VALUETYPE", Name,
IsInteger && IsVector && !IsScalable);
@@ -92,7 +92,7 @@ void VTEmitter::run(raw_ostream &OS) {
<< Name << ", "
<< Value << ", "
<< VT->getValueAsInt("Size") << ", "
- << VT->getValueAsInt("isOverloaded") << ", "
+ << VT->getValueAsBit("isOverloaded") << ", "
<< (IsInteger ? Name[0] == 'i' ? 3 : 1 : 0) << ", "
<< (IsFP ? Name[0] == 'f' ? 3 : 1 : 0) << ", "
<< IsVector << ", "
@@ -111,14 +111,14 @@ void VTEmitter::run(raw_ostream &OS) {
OS << "#ifdef GET_VT_VECATTR // (Ty, Sc, nElem, ElTy, ElSz)\n";
for (const auto *VT : VTsByNumber) {
- if (!VT || !VT->getValueAsInt("isVector"))
+ if (!VT || !VT->getValueAsBit("isVector"))
continue;
const auto *ElTy = VT->getValueAsDef("ElementType");
assert(ElTy);
// clang-format off
OS << " GET_VT_VECATTR("
<< VT->getValueAsString("LLVMName") << ", "
- << VT->getValueAsInt("isScalable") << ", "
+ << VT->getValueAsBit("isScalable") << ", "
<< VT->getValueAsInt("nElem") << ", "
<< ElTy->getName() << ", "
<< ElTy->getValueAsInt("Size") << ")\n";
More information about the llvm-commits
mailing list