[llvm] [AArch64][TargetParser] Move ExtensionDependencies into tablegen [NFC] (PR #93614)

Tomas Matheson via llvm-commits llvm-commits at lists.llvm.org
Wed May 29 03:23:29 PDT 2024


================
@@ -166,6 +166,12 @@ void AArch64::ExtensionSet::enable(ArchExtKind E) {
   Touched.set(E);
   Enabled.set(E);
 
+  // FIXME: Tablegen has the Subtarget Feature FeatureRCPC_IMMO which is implied
+  // by FeatureRCPC3 and in turn implies FeatureRCPC. The proper fix is to make
+  // FeatureRCPC_IMMO an Extension but that will expose it to the command line.
+  if (E == AEK_RCPC3)
+    enable(AEK_RCPC);
+
----------------
tmatheson-arm wrote:

Shame this is the only exception. Would it be better to put this exception into the tablegen emitter, so that at least all the dependency info is still contained in the generated `ExtensionDependencies`?

https://github.com/llvm/llvm-project/pull/93614


More information about the llvm-commits mailing list