[lld] [llvm] [WebAssembly] Add exnref type (PR #93586)

Derek Schuff via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 11:06:49 PDT 2024


================
@@ -137,6 +137,10 @@ class WebAssemblyFastISel final : public FastISel {
       if (Subtarget->hasReferenceTypes())
         return VT;
       break;
+    case MVT::exnref:
+      if (Subtarget->hasReferenceTypes() && Subtarget->hasExceptionHandling())
----------------
dschuff wrote:

I just noticed it here but this is more of a general question: should we just always assume that hasExceptionHandling will imply hasReferenceTypes (and maybe put some assertions somewhere in addition to whatever user-facing errors we have) rather than always having to test for both features?

https://github.com/llvm/llvm-project/pull/93586


More information about the llvm-commits mailing list