[llvm] [Support] Refactor getN1Bits so it does not work around any g++ bug (PR #78933)
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 08:01:08 PDT 2024
preames wrote:
> @AtariDreams It doesn't appear like this PR (or #87560, #87313, #85162, or #91386) have been approved by a reviewer? The LLVM review policy technically does allow post-commit review, but that is typically de-facto reserved for code owners working in their specific area. These PRs should probably be reverted until they are adequately reviewed.
I want to state this far more strongly. Landing PRs without appropriate review is a significant violation of the review policy and our developer practices. This is wildly inappropriate, and if continued would be a reason for revoking commit rights entirely.
In your case, please err strongly towards waiting on review. Only commit without pre-review if you have established trust with contributors in a given area. As an observer, it seems clear you have lost any trust you may have built, so please do *not* land a change without pre review at all for near future.
https://github.com/llvm/llvm-project/pull/78933
More information about the llvm-commits
mailing list