[llvm] [RemoveDIs] Add a 'BeforeDbgRecords' parameter to C API isnt insertion functions (PR #92417)

[Orlando Cazalet-Hyams via llvm-commits]

OCHyams wrote:

Ping @nikic wdyt of the discussion above?

@alan-j-hu 
> If LLVMPositionBuilder and LLVMPositionBuilder2 are intended to co-exist - i.e., the latter is not intended to replace the former in any future release, I'm wondering if LLVMPositionBuilder2 should have a more descriptive name. [...]

I think that makes sense but I'm struggling to think of a suitable name (any ideas?). An alternative could be to drop the bool argument from the new functions and add a "BeforeDbgRecords" suffix to the names (though this leaves with with `PositionBuilderBeforeDbgRecords` and `PositionBuilderBeforeBeforeDbgRecords`, the latter of which is ugly and looks like a typo). @nikic do you have an opinion on using `2` in the name for functions that are not getting deprecated?


https://github.com/llvm/llvm-project/pull/92417