[llvm] update_llc_test_checks: better support for non-llc tools (PR #93135)

Jannik Silvanus via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 04:37:39 PDT 2024


Nicolai =?utf-8?q?H=C3=A4hnle?= <nicolai.haehnle at amd.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/93135 at github.com>


================
@@ -101,7 +111,9 @@ def main():
                 from UpdateTestChecks import asm as output_type
 
             common.verify_filecheck_prefixes(filecheck_cmd)
-            if llc_tool not in LLC_LIKE_TOOLS:
+            if llc_tool not in LLC_LIKE_TOOLS and (
+                not ti.args.tool or llc_tool != ti.args.tool
+            ):
----------------
jasilvanus wrote:

Nit: I'd find the following simpler to understand:

```python
llc_like_tools = DEFAULT_LLC_LIKE_TOOLS
if ti.args.tool:
   llc_like_tools.append(ti.args.tool)
if llc_tool not in llc_like_tools:
```

https://github.com/llvm/llvm-project/pull/93135


More information about the llvm-commits mailing list