[llvm] [mlir][Bazel] Add a comment and move deps list into an extra line. (PR #93453)

Adrian Kuegel via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 02:57:23 PDT 2024


https://github.com/akuegel created https://github.com/llvm/llvm-project/pull/93453

This is a non-functional change in OSS, but makes it easier for downstream users to run transforms on this target.

>From 290fad3c7d80481abaf2c51ead9143e596dcb550 Mon Sep 17 00:00:00 2001
From: Adrian Kuegel <akuegel at google.com>
Date: Mon, 27 May 2024 09:54:51 +0000
Subject: [PATCH] [mlir][Bazel] Add a comment and move deps list into an extra
 line.

This is a non-functional change in OSS, but makes it easier for
downstream users to run transforms on this target.
---
 .../llvm-project-overlay/mlir/BUILD.bazel     | 28 +++++++++++--------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index a7bbe459fd9d7..a2f202235398a 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -6270,18 +6270,22 @@ cc_library(
     srcs = ["lib/Target/LLVM/NVVM/Target.cpp"],
     hdrs = glob(["include/mlir/Target/LLVM/NVVM/*.h"]),
     includes = ["include"],
-    deps = [
-        ":GPUDialect",
-        ":GPUToLLVMIRTranslation",
-        ":LLVMToLLVMIRTranslation",
-        ":NVVMDialect",
-        ":NVVMToLLVMIRTranslation",
-        ":TargetLLVM",
-        ":ToLLVMIRTranslation",
-        "//llvm:NVPTXCodeGen",
-        "//llvm:Support",
-        "//llvm:config",
-    ],
+    deps =
+        # Start the deps list in an extra line. This makes it easier for
+        # downstream users to transform the BUILD file and add extra deps behind
+        # guards.
+        [
+            ":GPUDialect",
+            ":GPUToLLVMIRTranslation",
+            ":LLVMToLLVMIRTranslation",
+            ":NVVMDialect",
+            ":NVVMToLLVMIRTranslation",
+            ":TargetLLVM",
+            ":ToLLVMIRTranslation",
+            "//llvm:NVPTXCodeGen",
+            "//llvm:Support",
+            "//llvm:config",
+        ],
 )
 
 td_library(



More information about the llvm-commits mailing list