[llvm] [llvm] Use SmallString::str (NFC) (PR #92712)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sun May 19 18:33:05 PDT 2024
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/92712
None
>From f2c04bc9a0455f1de315e60af194e642c8a5d899 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sun, 19 May 2024 17:46:17 -0700
Subject: [PATCH] [llvm] Use SmallString::str (NFC)
---
llvm/lib/Bitcode/Reader/BitcodeReader.cpp | 2 +-
llvm/lib/CodeGen/ParallelCG.cpp | 4 +---
llvm/lib/LTO/LTOBackend.cpp | 5 ++---
3 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
index e64051cf53862..c9295344f8080 100644
--- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
+++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
@@ -2940,7 +2940,7 @@ Error BitcodeReader::parseValueSymbolTable(uint64_t Offset) {
if (!BB)
return error("Invalid bbentry record");
- BB->setName(StringRef(ValueName.data(), ValueName.size()));
+ BB->setName(ValueName.str());
ValueName.clear();
break;
}
diff --git a/llvm/lib/CodeGen/ParallelCG.cpp b/llvm/lib/CodeGen/ParallelCG.cpp
index ceb64b2badab5..8ab64f8afe6ec 100644
--- a/llvm/lib/CodeGen/ParallelCG.cpp
+++ b/llvm/lib/CodeGen/ParallelCG.cpp
@@ -79,9 +79,7 @@ void llvm::splitCodeGen(
[TMFactory, FileType, ThreadOS](const SmallString<0> &BC) {
LLVMContext Ctx;
Expected<std::unique_ptr<Module>> MOrErr = parseBitcodeFile(
- MemoryBufferRef(StringRef(BC.data(), BC.size()),
- "<split-module>"),
- Ctx);
+ MemoryBufferRef(BC.str(), "<split-module>"), Ctx);
if (!MOrErr)
report_fatal_error("Failed to read bitcode");
std::unique_ptr<Module> MPartInCtx = std::move(MOrErr.get());
diff --git a/llvm/lib/LTO/LTOBackend.cpp b/llvm/lib/LTO/LTOBackend.cpp
index d4b89ede2d713..21aed799d6fa3 100644
--- a/llvm/lib/LTO/LTOBackend.cpp
+++ b/llvm/lib/LTO/LTOBackend.cpp
@@ -452,9 +452,8 @@ static void splitCodeGen(const Config &C, TargetMachine *TM,
CodegenThreadPool.async(
[&](const SmallString<0> &BC, unsigned ThreadId) {
LTOLLVMContext Ctx(C);
- Expected<std::unique_ptr<Module>> MOrErr = parseBitcodeFile(
- MemoryBufferRef(StringRef(BC.data(), BC.size()), "ld-temp.o"),
- Ctx);
+ Expected<std::unique_ptr<Module>> MOrErr =
+ parseBitcodeFile(MemoryBufferRef(BC.str(), "ld-temp.o"), Ctx);
if (!MOrErr)
report_fatal_error("Failed to read bitcode");
std::unique_ptr<Module> MPartInCtx = std::move(MOrErr.get());
More information about the llvm-commits
mailing list