[clang] [llvm] [MC,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 07:50:38 PDT 2024


================
@@ -123,6 +123,12 @@ class ContiguousBlobAccumulator {
     return encodeULEB128(Val, OS);
   }
 
+  unsigned writeSLEB128(int64_t Val) {
+    if (!checkLimit(10))
----------------
smithp35 wrote:

I'm guessing 10 is from 64-bits extended to 10 groups of 7-bits extended to 8.

Unless I've misunderstood I note that writeULEB128 above uses sizeof(uint64_t) which may be a little too low.

https://github.com/llvm/llvm-project/pull/91280


More information about the llvm-commits mailing list