[llvm] [FileCheck] improve prefix validation (PR #92248)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Thu May 16 14:28:33 PDT 2024


================
@@ -2486,6 +2489,14 @@ static bool ValidatePrefixes(StringRef Kind, StringSet<> &UniquePrefixes,
              << "check and comment prefixes: '" << Prefix << "'\n";
       return false;
     }
+    for (StringRef Directive : Directives) {
----------------
MaskRay wrote:

> Has it caused issues?

@klensy reported that
https://github.com/llvm/llvm-project/blame/main/lld/test/ELF/arm-exidx-shared.s used `// RUN: llvm-objdump -s --triple=armv7a-none-linux-gnueabi %t2 | FileCheck --check-prefix=CHECK-EXTAB-NEXT %s`.

`CHECK-EXTAB-NEXT` was very confusing. I fixed it.

https://github.com/llvm/llvm-project/pull/92248


More information about the llvm-commits mailing list