[llvm] [DebugCounter] Add support for non-continous ranges. (PR #89470)

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Thu May 16 12:47:32 PDT 2024


================
@@ -53,6 +54,18 @@ namespace llvm {
 
 class raw_ostream;
 
+struct Chunk {
----------------
nhaehnle wrote:

"Chunk" is an extremely generic name for something to exist globally in the `llvm` namespace. Please change this to reduce the risk of name collisions. For example, you could make it a nested struct in `DebugCounter`, or rename it to `DebugCounterChunk`.

(And change `{print,parse}Chunks` function analogously.)

https://github.com/llvm/llvm-project/pull/89470


More information about the llvm-commits mailing list