[llvm] [DebugCounter] Add support for non-continous ranges. (PR #89470)

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Thu May 16 12:47:31 PDT 2024


https://github.com/nhaehnle commented:

Hi, sorry it's been taking so long! I think this is a very nice addition to the DebugCounter functionality indeed.

Would you mind splitting the bisector changes out in a separate PR? It's not immediately obvious to me what it is for, and it seems likely to be logically independent. (IIUC, I think you'd have one PR for the DebugCounter changes + delta-driver, and one PR for the PassManager changes + bisector?)

I have a bunch of comments inline, and high-level comments:

* I'm not convinced by the `delta-driver` name. The name should have some connection to the DebugCounter facility. The previous tool is called bisect-skip-count. Maybe something like "minimize-debug-counter" for the new tool?
* Take the GitHub Actions complaints seriously; this means formatting feedback and the test failures.

With those notes addressed, I'd be happy to see this change go in.

https://github.com/llvm/llvm-project/pull/89470


More information about the llvm-commits mailing list