[lld] [llvm] [Symbolizer] Support for Missing Line Numbers. (PR #82240)

via llvm-commits llvm-commits at lists.llvm.org
Thu May 16 03:49:33 PDT 2024


================
@@ -0,0 +1,261 @@
+# REQUIRES: x86-registered-target
+
+# RUN: clang -O3 -gline-tables-only -T%S/linker-script.ld --target=x86_64-pc-linux %s -o %t.o
----------------
ampandey-1995 wrote:


> If this is complex, perhaps `cross-project-tests/debuginfo-tests/` can be used.

Yes, This test is complex in the sense as we are creating a custom section to have another sequence apart from .text sequence. So as per @dwblaikie request to add a lit test which properly check the sequence boundaries for approximation. To cover that requirement a minimum of two sections has to be created. These two sections(.text & custom section) will have corresponding end_sequence flag setup in the final object file when line table is parsed by the llvm-symbolizer.  we then use llvm-symbolizer binary to check if approximation is enabled then it shouldn't cross sequence boundaries.

Ok, but where to add these in ```cross-project-tests/debuginfo-tests```?
Should I create a new directory, in ```cross-project-tests/debuginfo-tests``` ? 
Is it ok to create a directory ```llvm-symbolizer-tests```  in ```cross-project-tests/debuginfo-tests``` ?

If added into ```cross-project-tests/debuginfo-tests``` then how upstream CI would execute a check for this?


https://github.com/llvm/llvm-project/pull/82240


More information about the llvm-commits mailing list