[llvm] [Reassociate] Drop weight reduction to fix issue 91417 (PR #91469)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 19:58:47 PDT 2024


nikic wrote:

> > The original patch says:
> > > This patch fixes the computation of weights by correctly computing them no matter how big they are, rather than just overflowing and getting a wrong value.
> > 
> > 
> > Is "wrong" here in the sense that if overflow happens there may be a miscompile or "wrong" in the sense that the result may be sup-optimal?
> 
> See https://bugs.llvm.org/show_bug.cgi?id=13021. The original patch fixes the infinite loop. Reducing weights is just a "side-effect".

Will reverting this bring back the infinite loop?

https://github.com/llvm/llvm-project/pull/91469


More information about the llvm-commits mailing list