[llvm] [TableGen][SubtargetEmitter] Early exit from loop in FindWriteResources and FindReadAdvance (PR #92202)
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Wed May 15 10:30:16 PDT 2024
================
@@ -956,8 +962,14 @@ Record *SubtargetEmitter::FindReadAdvance(const CodeGenSchedRW &SchedRead,
for (Record *RA : ProcModel.ReadAdvanceDefs) {
if (!RA->isSubClassOf("ReadAdvance"))
continue;
- if (AliasDef == RA->getValueAsDef("ReadType") ||
- SchedRead.TheDef == RA->getValueAsDef("ReadType")) {
+ // If there is no AliasDef and we find a match, we can early exit since
+ // there is no need to verify whether there are resources defined for both
+ // SchedWrite and its alias.
+ if (!AliasDef && AliasDef == RA->getValueAsDef("ReadType")) {
----------------
topperc wrote:
Should this be `!AliasDef && SchedRead.TheDef == RA->getValueAsDef("ReadType")`?
https://github.com/llvm/llvm-project/pull/92202
More information about the llvm-commits
mailing list