[llvm] [LoopUnroll] Ignore inlinable calls if unrolling is forced (#88141) (PR #88149)

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 08:34:42 PDT 2024


https://github.com/aeubanks commented:

the PrepareForLTO portion needs testing. you'll need to add parsing code for something like `-passes='loop-unroll-full<prepare-for-lto>'`, grep for `parseLoopRotateOptions` for an example

also, isn't this still going to result in the remark getting printed in the pre-link optimization pipeline? I think we should treat the PrepareForLTO and the call heuristic as two separate issues and go back to the original PR, splitting out the PrepareForLTO change

please move the issue being fixed from the commit title to the commit message like `Fixes #88141`, otherwise it's confusing with the PR number

https://github.com/llvm/llvm-project/pull/88149


More information about the llvm-commits mailing list