[llvm] [mlir] Add missing return on nullptr check (PR #92125)
Oleksandr Alex Zinenko via llvm-commits
llvm-commits at lists.llvm.org
Tue May 14 11:56:21 PDT 2024
================
@@ -654,7 +654,7 @@ LogicalResult transform::ApplyConversionPatternsOp::verify() {
InFlightDiagnostic diag = emitOpError()
<< "expected default converter child op to "
"implement TypeConverterBuilderOpInterface";
- diag.attachNote(typeConverterOp->getLoc()) << "op without interface";
+ diag.attachNote(typeConverterRegion.front().front()->getLoc()) << "op without interface";
----------------
ftynse wrote:
> Yes, it fixes second bug described in #92123
Please consider a separate patch for this. It belongs to a different subproject and doesn't match the commit message, there is no missing return here.
https://github.com/llvm/llvm-project/pull/92125
More information about the llvm-commits
mailing list