[clang] [libclc] [llvm] [openmp] [Clang] `__attribute__((assume))` refactor (PR #84934)

Erich Keane via llvm-commits llvm-commits at lists.llvm.org
Tue May 14 06:57:39 PDT 2024


erichkeane wrote:

> > @Sirraide, would you add those (or similar if you feel that changes are needed) directly to that PR?
> 
> Yeah, that looks reasonable. If this works for clspv, then I’ll integrate these changes into this pr.
> 
> That means I can remove the `omp_assume` spelling for `[[omp::assume]]` that this pr was going to add as a temporary measure, because that’s not going to be needed anymore.

Thats fantastic!

However, I'd suggest instead adding the clspv attribute in a separate review/commit.  It isn't really related to this one, other than this has a slight dependency on it.

https://github.com/llvm/llvm-project/pull/84934


More information about the llvm-commits mailing list