[llvm] [Support] Handle delete_pending case for Windows fs::status (PR #90655)
Eli Friedman via llvm-commits
llvm-commits at lists.llvm.org
Mon May 13 10:24:43 PDT 2024
================
@@ -785,9 +785,20 @@ std::error_code status(const Twine &path, file_status &result, bool Follow) {
DWORD Flags = FILE_FLAG_BACKUP_SEMANTICS;
if (!Follow) {
- DWORD attr = ::GetFileAttributesW(path_utf16.begin());
- if (attr == INVALID_FILE_ATTRIBUTES)
- return getStatus(INVALID_HANDLE_VALUE, result);
+ DWORD attr;
+
+ // If getting file attributes fails due to a pending deletion, try
+ // again in a loop to avoid returning a misleading permission denied
+ // error.
+ for (int Retry = 200; Retry >= 0; --Retry) {
+ attr = ::GetFileAttributesW(path_utf16.begin());
+ if (attr != INVALID_FILE_ATTRIBUTES)
+ break;
+ std::error_code code = getStatus(INVALID_HANDLE_VALUE, result);
+ if (code != llvm::errc::delete_pending || !Retry)
+ return code;
+ ::Sleep(15);
----------------
efriedma-quic wrote:
Looking a bit more, I found that you can avoid hitting this error code in some cases by changing how you delete files: if you rename a file before deleting it, that frees the name immediately, instead of waiting for the remaining handles to be closed. Does that apply here?
https://github.com/llvm/llvm-project/pull/90655
More information about the llvm-commits
mailing list