[lld] [llvm] [RISCV] Support .note.gnu.property for enable Zicfiss and Zicfilp extension (PR #77414)

via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 06:24:08 PDT 2024


================
@@ -118,6 +147,19 @@ void RISCVTargetELFStreamer::finish() {
   }
 
   MCA.setELFHeaderEFlags(EFlags);
+
+  unsigned GNUNoteFlags = 0;
+
+  // check ZICFILP or ZICFISS with features
+  // TODO should we check with codegen enable ex. -mllvm
----------------
SuHo-llrr wrote:

Yes, I think we shouldn't just check if there is CFI extension is on, 
we should also check if the codegen options are really enabled.
Ex. following code in RISCVFrameLowering

@yetingk  Do you think so?

```
if (!STI.hasForcedSWShadowStack() && STI.hasStdExtZicfiss()) {
  BuildMI(MBB, MI, DL, TII->get(RISCV::SSPUSH)).addReg(RAReg);
    return;
  }
```



https://github.com/llvm/llvm-project/pull/77414


More information about the llvm-commits mailing list