[compiler-rt] [ASan] Remove COMPILER_RT_ASAN_SHADOW_SCALE_DEFINITION. (PR #91832)

via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 00:11:30 PDT 2024


https://github.com/Enna1 updated https://github.com/llvm/llvm-project/pull/91832

>From a373f6b1c00bbc9c02bb54626b69428b94bec8ad Mon Sep 17 00:00:00 2001
From: "xumingjie.enna1" <xumingjie.enna1 at bytedance.com>
Date: Sat, 11 May 2024 11:14:24 +0800
Subject: [PATCH 1/2] [ASan] Remove COMPILER_RT_ASAN_SHADOW_SCALE_DEFINITION.

Since the set of COMPILER_RT_ASAN_SHADOW_SCALE_DEFINITION is removed in commit 8421fa5d536aadf42c0e54c566bc439a40ebdb8e,
cleanup the use of COMPILER_RT_ASAN_SHADOW_SCALE_DEFINITION.
---
 compiler-rt/lib/asan/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler-rt/lib/asan/CMakeLists.txt b/compiler-rt/lib/asan/CMakeLists.txt
index 601750f72175d..a4a10bb331b58 100644
--- a/compiler-rt/lib/asan/CMakeLists.txt
+++ b/compiler-rt/lib/asan/CMakeLists.txt
@@ -88,7 +88,7 @@ set(ASAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})
 
 append_list_if(MSVC /Zl ASAN_CFLAGS)
 
-set(ASAN_COMMON_DEFINITIONS ${COMPILER_RT_ASAN_SHADOW_SCALE_DEFINITION})
+set(ASAN_COMMON_DEFINITIONS)
 
 append_rtti_flag(OFF ASAN_CFLAGS)
 

>From 50d1106a0ba051df501f6a682446964fcedd9a51 Mon Sep 17 00:00:00 2001
From: "xumingjie.enna1" <xumingjie.enna1 at bytedance.com>
Date: Mon, 13 May 2024 15:11:10 +0800
Subject: [PATCH 2/2] address review comments

---
 compiler-rt/lib/asan/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler-rt/lib/asan/CMakeLists.txt b/compiler-rt/lib/asan/CMakeLists.txt
index a4a10bb331b58..463ea233b37aa 100644
--- a/compiler-rt/lib/asan/CMakeLists.txt
+++ b/compiler-rt/lib/asan/CMakeLists.txt
@@ -88,7 +88,7 @@ set(ASAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})
 
 append_list_if(MSVC /Zl ASAN_CFLAGS)
 
-set(ASAN_COMMON_DEFINITIONS)
+set(ASAN_COMMON_DEFINITIONS "")
 
 append_rtti_flag(OFF ASAN_CFLAGS)
 



More information about the llvm-commits mailing list