[llvm] llvm/lib/CodeGen/TargetSchedule.cpp:132:12: warning: Assert statement modifies 'NIter' (PR #90982)

Youngsuk Kim via llvm-commits llvm-commits at lists.llvm.org
Sat May 4 03:37:39 PDT 2024


JOE1994 wrote:

Could you update the title of the commit to something like `"[llvm] Move variable update out of assert (NFC)"` ?
For LLVM commit message titles, it is standard practice to use headers indicating the updated code area, and then add summary of the change. "NFC" at the end means "No Functional Change".

 I'd also suggest to move the "`closes #90328`" message from the title to the _body_ of the commit message.

https://github.com/llvm/llvm-project/pull/90982


More information about the llvm-commits mailing list