[llvm] f16e234 - [InstCombine] Do not request non-splat vector support in code reviews (NFC) (#90709)

[via llvm-commits]

Author: Nikita Popov
Date: 2024-05-04T16:01:36+09:00
New Revision: f16e234f1126f6646609b6918a37c8eb32c8fb3e

URL: https://github.com/llvm/llvm-project/commit/f16e234f1126f6646609b6918a37c8eb32c8fb3e
DIFF: https://github.com/llvm/llvm-project/commit/f16e234f1126f6646609b6918a37c8eb32c8fb3e.diff

LOG: [InstCombine] Do not request non-splat vector support in code reviews (NFC) (#90709)

The InstCombine contributor guide already says:

> Handle non-splat vector constants if doing so is free, but do
> not add handling for them if it adds any additional complexity
> to the code.

This change strengthens this guideline to explicitly discourage
asking (new) contributors to implement non-splat support during code
reviews. Doing so will almost certainly increase the number of
necessary review iterations, or result in outright contradictory review
feedback, as different people are willing to accept a different degree
of complexity for non-splat vector support.

Added: 
    

Modified: 
    llvm/docs/InstCombineContributorGuide.md

Removed: 
    


################################################################################
diff  --git a/llvm/docs/InstCombineContributorGuide.md b/llvm/docs/InstCombineContributorGuide.md
index 2416fd0920f62c..ce5f958058c550 100644
--- a/llvm/docs/InstCombineContributorGuide.md
+++ b/llvm/docs/InstCombineContributorGuide.md
@@ -554,3 +554,11 @@ guidelines.
    use of ValueTracking queries. Whether this makes sense depends on the case,
    but it's usually a good idea to only handle the constant pattern first, and
    then generalize later if it seems useful.
+
+## Guidelines for reviewers
+
+ * Do not ask new contributors to implement non-splat vector support in code
+   reviews. If you think non-splat vector support for a fold is both
+   worthwhile and policy-compliant (that is, the handling would not result in
+   any appreciable increase in code complexity), implement it yourself in a
+   follow-up patch.