[llvm] [PowerPC][AIX] 64-bit large code-model support for toc-data (PR #90619)
zhijian lin via llvm-commits
llvm-commits at lists.llvm.org
Fri May 3 06:24:05 PDT 2024
================
@@ -1148,21 +1148,21 @@ void PPCAsmPrinter::emitInstruction(const MachineInstr *MI) {
MCSymbolRefExpr::VariantKind VK = GetVKForMO(MO);
- // If the symbol isn't toc-data then use the TOC on AIX.
+ // If the symbol does not have the toc-data attribute, then we create the
+ // TOC entry on AIX. If the toc-data attribute is used, the TOC entry
+ // contains the data rather than the address of the MOSymbol.
----------------
diggerlin wrote:
I am not sure whether it is reasonable to change the order the comment.
I am prefer to keep the original order
// Map the global address operand to be a reference to the TOC entry we
// will synthesize later. 'TOCEntry' is a label used to reference the
// storage allocated in the TOC which contains the address of 'MOSymbol'.
// If the symbol does not have the toc-data attribute, then we create the
// TOC entry on AIX. If the toc-data attribute is used, the TOC entry
// contains the data rather than the address of the MOSymbol.
but feel free to keep your comment if you think it is reasonable,
https://github.com/llvm/llvm-project/pull/90619
More information about the llvm-commits
mailing list