[llvm] Attributor: Add denormal-fp-math to attributor-light (PR #79576)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 23:32:24 PDT 2024


nikic wrote:

> > I think it's quite unlikely that AttributorLight will become part of the default pipeline anytime soon, especially if more attributes get added to it. So if you need this, you do need to implement it in the production FunctionAttrs pass. Unless this is a for a custom, non-upstream pipeline?
> 
> Could you elaborate why that is?

If I remember correctly, AttributorLight still causes large compile-time regressions and nobody is actively working on it. I wanted to do a quick check of the current state just now, but ... it seems like we don't even have an option to use AttributorLight in the default pipeline yet?

The pass is not going to magically turn itself on, someone needs to actively pursue that, and adding more attributes to it before it gets turned on is not the right way to go about it.

https://github.com/llvm/llvm-project/pull/79576


More information about the llvm-commits mailing list