[llvm] Merge sourcelocation in CSEMIRBuilder::getDominatingInstrForID. (PR #90922)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 22:22:02 PDT 2024


================
@@ -856,8 +856,9 @@ class MachineIRBuilder {
   ///      type.
   ///
   /// \return The newly created instruction.
-  virtual MachineInstrBuilder buildConstant(const DstOp &Res,
-                                            const ConstantInt &Val);
+  virtual MachineInstrBuilder
+  buildConstant(const DstOp &Res, const ConstantInt &Val,
+                SmallVectorImpl<DILocation *> *Locs = nullptr);
----------------
arsenm wrote:

Do we really have to pollute the public API with this? Can't this remain an internal implementation detail? 

https://github.com/llvm/llvm-project/pull/90922


More information about the llvm-commits mailing list