[llvm] [InstCombine] Do not request non-splat vector support in code reviews (NFC) (PR #90709)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 20:13:42 PDT 2024


================
@@ -554,3 +554,11 @@ guidelines.
    use of ValueTracking queries. Whether this makes sense depends on the case,
    but it's usually a good idea to only handle the constant pattern first, and
    then generalize later if it seems useful.
+
+## Guidelines for reviewers
+
+ * Do not ask contributors to implement non-splat vector support in code
----------------
nikic wrote:

Done. The problem is not just that it can be complicated, but that it is likely to significantly increase the number of required review iterations or even result in directly contradictory review feedback. We don't have a strong consensus on what exactly is acceptable when implementing non-splat vector support or what the best way of going about it is.

https://github.com/llvm/llvm-project/pull/90709


More information about the llvm-commits mailing list