[lld] [llvm] Reapply "Use an abbrev to reduce size of VALUE_GUID records in ThinLTO summaries" (#90610) (PR #90692)

Kamau Bridgeman via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 15:11:25 PDT 2024


kamaub wrote:

It appears this change has exposed an issue with the test case, [compiler-rt/test/profile/instrprof-gc-sections.c](https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/profile/instrprof-gc-sections.c), failing on [clang-ppc64le-linux-multistage](https://lab.llvm.org/buildbot/#/builders/121), first build[41260](https://lab.llvm.org/buildbot/#/builders/121/builds/41260), and  [clang-ppc64le-linux-test-suite](https://lab.llvm.org/buildbot/#/builders/230), first build[27968](https://lab.llvm.org/buildbot/#/builders/230/builds/27968). Neither bot builds or links with `lld`, all the tested binaries are linked with `ld` on purpose as we already had `lld` buildbots yet the `// REQUIRES: lld-available` check/guard passes anyway after detecting an lld linker available elsewhere on the host machine. I think the correct behavior would be for it to only search the build directory that the test case is suppose to test.

A solution is not known yet, I wanted to bring this up here for discussion so we could work towards one.

https://github.com/llvm/llvm-project/pull/90692


More information about the llvm-commits mailing list