[clang] [llvm] [DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version (PR #90809)

S. Bharadwaj Yadavalli via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 09:45:52 PDT 2024


================
@@ -115,6 +115,30 @@ StringRef Triple::getArchName(ArchType Kind, SubArchType SubArch) {
     if (SubArch == AArch64SubArch_arm64e)
       return "arm64e";
     break;
+  case Triple::dxil:
+    switch (SubArch) {
+    case Triple::NoSubArch:
----------------
bharadwajy wrote:

> Why default is dxil1.0?

No specific reason other than choose the most basic version. 

Your comment [here](https://github.com/llvm/llvm-project/pull/89823#discussion_r1581541937) appeared to indicate a similar default choice for SPIRV (viz., spirv32 being equivalent to spirv32_v1.0).

I am open to suggestions for alternate default DXIL version choices.

https://github.com/llvm/llvm-project/pull/90809


More information about the llvm-commits mailing list