[llvm] [NFC][LLVM] Refactor rounding mode detection of constrained fp intrinsic IDs (PR #90854)
Paul Walker via llvm-commits
llvm-commits at lists.llvm.org
Thu May 2 09:39:49 PDT 2024
================
@@ -1491,7 +1491,19 @@ bool Intrinsic::isConstrainedFPIntrinsic(ID QID) {
#define INSTRUCTION(NAME, NARG, ROUND_MODE, INTRINSIC) \
case Intrinsic::INTRINSIC:
#include "llvm/IR/ConstrainedOps.def"
+#undef INSTRUCTION
return true;
+ default:
+ return false;
+ }
+}
+
+bool Intrinsic::hasConstrainedFPRoundingModeOperand(Intrinsic::ID QID) {
----------------
paulwalker-arm wrote:
Thanks for highlighting this. I'll reassess my next steps to see if I can do something better for target intrinsics rather than repeating the same mistakes as with the existing constrained ones. I had naively assumed the design had settled.
https://github.com/llvm/llvm-project/pull/90854
More information about the llvm-commits
mailing list